Python: Support ternary comparisons in PatternMatchingComparator#6809
Merged
knutwannheden merged 1 commit intomainfrom Feb 24, 2026
Merged
Python: Support ternary comparisons in PatternMatchingComparator#6809knutwannheden merged 1 commit intomainfrom
knutwannheden merged 1 commit intomainfrom
Conversation
macsux
pushed a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_compare_ternarymethod toPatternMatchingComparatorto properly comparej.Ternary(conditional expression) nodes by recursively comparing condition, true_part, and false_partTruewithout deep comparison, causing incorrect matchesTest plan
TestTernaryMatchingtests: placeholder captures, concrete match, condition/true_part/false_part mismatches